You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The GoogleMap() IndoorStateChangeListener parameter currently uses DefaultIndoorStateChangeListener as a default value instead of null. This is inconsistent with all other map listener callback parameters that were changed to default to null in #320.
I propose making this parameter nullable and using a null default, as well as removing the DefaultIndoorStateChangeListener object, which is no longer useful. This is an API-breaking change.
The text was updated successfully, but these errors were encountered:
I will make a PR after #478 is merged. The two changes overlap.
bubenheimer
changed the title
GoogleMap(): make IndoorStateChangeListener parameter nullable instead of using DefaultIndoorStateChangeListener as a default parameter
GoogleMap(): non-nullable indoorStateChangeListener parameter is inconsistent with other listener parameters
Dec 16, 2023
I've changed my mind on this subject. I no longer think this should be changed: the IndoorStateChangeListener must always remain set on the GoogleMap SDK, because of its special semantics where setting it twice is not possible.
The current API reflects well the semantics that the IndoorStateChangeListener is always set.
android-maps-compose 4.3.0
The GoogleMap() IndoorStateChangeListener parameter currently uses DefaultIndoorStateChangeListener as a default value instead of null. This is inconsistent with all other map listener callback parameters that were changed to default to null in #320.
I propose making this parameter nullable and using a null default, as well as removing the DefaultIndoorStateChangeListener object, which is no longer useful. This is an API-breaking change.
The text was updated successfully, but these errors were encountered: