feat: add Project.latestRelease to track latest release
#1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aofei
commented
Oct 29, 2024
| @@ -404,19 +404,11 @@ export class Project extends Disposable { | |||
| } | |||
|
|
|||
| /** Load from cloud */ | |||
| async loadFromCloud(owner: string, name: string, signal?: AbortSignal) { | |||
| const { metadata, files } = await cloudHelper.load(owner, name, signal) | |||
| async loadFromCloud(owner: string, name: string, preferReleasedContent: boolean = false, signal?: AbortSignal) { | |||
There was a problem hiding this comment.
尝试了一下把 latestRelease 的概念写进来，但发现会让事情变复杂，所以还是保留了目前这种 load 时指明 prefer released content 的做法
nighca
reviewed
Oct 29, 2024
Fixes goplus#1037 Fixes goplus#1033 Signed-off-by: Aofei Sheng <[email protected]>
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
nighca
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Fixes #1033