Support property anim, based on timeline #368
Open
+901
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiepengTan
reviewed
Oct 30, 2024
| r.fadeOut.Step(min) | ||
| } | ||
|
|
||
| goto CHECK_FADE_OUT |
There was a problem hiding this comment.
Please do not use goto.
There was a problem hiding this comment.
In most cases, the use of goto should be avoided. The exception is when it is the only clear and concise way to handle control flow. By ensuring that all cases ultimately check for a fade-out condition, the control flow remains clear and understandable.
JiepengTan
reviewed
Oct 30, 2024
| return nil | ||
| } | ||
|
|
||
| func (t *Tweener) From() ITweener { |
There was a problem hiding this comment.
Is this a clone function?
There was a problem hiding this comment.
Not a clone function. It's a reverse version of t.
qlli
force-pushed
the
propAnim
branch
2 times, most recently
from
25b7e8f
to
78d4186
Compare
nighca
reviewed
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeline and property animation (tweener animation)