Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Storage Rework - 4pts #58

Open
jakedcolbert opened this issue Jan 27, 2023 · 1 comment
Open

Reference Storage Rework - 4pts #58

jakedcolbert opened this issue Jan 27, 2023 · 1 comment
Assignees
Labels
Navigation Issue is a navigation feature

Comments

@jakedcolbert
Copy link

jakedcolbert commented Jan 27, 2023

  • Separate the current reference store into two stores: current and next.
  • Use the next store to update dropdown labels mid navigation.
  • navbar label should update to what the user selects in real time and then either:
    • Navigate to new reference on navigation completion
    • Abandon navigation and revert to current reference on navigation cancel
@jakedcolbert jakedcolbert self-assigned this Jan 27, 2023
@jakedcolbert jakedcolbert added the Navigation Issue is a navigation feature label Jan 27, 2023
@jakedcolbert jakedcolbert changed the title Reference Storage Rework Reference Storage Rework - 7 Feb 1, 2023
@jakedcolbert jakedcolbert changed the title Reference Storage Rework - 7 Reference Storage Rework - 7pts Feb 1, 2023
@jakedcolbert jakedcolbert changed the title Reference Storage Rework - 7pts Reference Storage Rework - 4pts Feb 1, 2023
@chrisvire
Copy link
Collaborator

I think you can leave the current group store for now and just implement a navRef which is the current navigation state. We determined that we can use the referenceStore type for this since is always defaults to a valid reference. So it will have to be a store with just an object like:

export const navRef = writable({ book: '', chapter: '' });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Navigation Issue is a navigation feature
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants