Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json unmarshal of payload does not support custom type errors #70

Open
lllwvlvwlll opened this issue Apr 9, 2019 · 0 comments
Open
Labels

Comments

@lllwvlvwlll
Copy link

lllwvlvwlll commented Apr 9, 2019

reference: https://github.com/gorilla/rpc/blob/master/v2/json2/server.go#L165

Per the link above, if using a custom type in args which fails to parse, resulting in a verbose error message, there is a false assumption that the json params is not a structured object.

The subsequent attempt to parse out into a map interface will also fail because the data is actually structured, but the content is malformed.

This results in a misleading error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants