Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"History" tab randomly disappears #2

Open
phptek opened this issue May 8, 2019 · 1 comment
Open

"History" tab randomly disappears #2

phptek opened this issue May 8, 2019 · 1 comment

Comments

@phptek
Copy link

phptek commented May 8, 2019

PHP 7.1 / Ubuntu 16.04 / silverstripe/framework 4.3.3

In DataObjectHistory::getHistoryFields(), there's a check which causes the "History" tab to disappear. It does this when you select the "Publish" button on your custom DataObject subclass.

Commenting out this check, fixes the problem. Not sure it's even needed as my system seems to work OK without it.

//        if (!$owner->isLatestVersion()) {
//            return null;
//        }
@sinan-evanshunt
Copy link

I confirm the same issue on my setup as well. And commenting out that if statement does make the History tab stay in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants