Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #3

Open
ZenoArrow opened this issue Oct 18, 2024 · 6 comments
Open

Dark mode #3

ZenoArrow opened this issue Oct 18, 2024 · 6 comments
Labels
feature-request Discussion about requested features

Comments

@ZenoArrow
Copy link

Would it be okay to have a dark mode for the Fesh UI? I try to stick to apps with dark modes where possible, as they tend to be much more comfortable to look at.

@goswinr goswinr added the feature-request Discussion about requested features label Oct 19, 2024
@goswinr
Copy link
Owner

goswinr commented Oct 22, 2024

That could work via https://github.com/Dirkster99/AvalonEditHighlightingThemes
I am also using a dark theme in VS code. But when I host Fesh in Rhino (or Revit) the host UI is light only, so that is why I use light for now.

@ZenoArrow
Copy link
Author

Thanks for looking into how this could be achieved @goswinr .

Just to point out, Rhino has supported dark mode for about a year...
https://www.rhino3d.com/features/user-interface/dark-mode/

... and Revit has some support for this too...

https://help.autodesk.com/view/RVT/2024/ENU/?guid=GUID-7CFE6DFD-CD70-445B-A3A3-3F470364B18C

It's possible other users of Rhino/Revit prefer to use a dark mode, so it could be good to start prepping for similar requests from these users.

@goswinr
Copy link
Owner

goswinr commented Oct 22, 2024

@ZenoArrow you are right, they actually have dark mode now! 🤔

@noncom
Copy link

noncom commented Feb 16, 2025

+1 for dark mode! I tried the portable version, can't look at the white thing at all.

@goswinr
Copy link
Owner

goswinr commented Feb 17, 2025

@noncom I personally like the white versions. I guess I am old school🤣. But I will take pull request for a dark mode. Do you or @ZenoArrow want do the main WPF UI? I have never done theming. It currently has no explicit theming, also there is no XAML, its all F#. I could then do the Editor itself.

@noncom
Copy link

noncom commented Feb 23, 2025

Well, it's not about style. I actually like how white and bright themes look. But my eyes physically are very much against that. I had to make myself get used to dark themes as I used to dislike them initially. From what I gathered from people I worked with over the years, this is the story of at least half of the people who use dark themes. Maybe some do use them from liking how they look, but that's not the prevalent reason for many.

At the same time I must say that I don't have much experience with XAML or F#, I'm just thinking about evaluating F#, so not sure if I'm able to provide a pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Discussion about requested features
Projects
None yet
Development

No branches or pull requests

3 participants