Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komga doesn't accept dates lower than 1000 #1864

Closed
5 tasks done
Eskuero opened this issue Feb 8, 2025 · 3 comments
Closed
5 tasks done

Komga doesn't accept dates lower than 1000 #1864

Eskuero opened this issue Feb 8, 2025 · 3 comments

Comments

@Eskuero
Copy link

Eskuero commented Feb 8, 2025

Steps to reproduce

  1. Try to change the publication date of a book via webui to year 999
  2. Additionally even if the dates were parsed, the webui date selector doesn't go into BC

Expected behavior

Writting was invented 5000 years ago. In fact I discovered this error because I added the "Epic of Gilgamesh" to my library and I was trying to set the correct date. The epub date was set to year 2500. Setting it to -2500 made Komga show it still as year 2500 for publication.

I don't know whether epub definition allows negative dates but imho Komga should allow the modification to the imported metadata via the webui.

Actual behavior

The webui shows a error and nothing changes.

Logs

2025-02-08T22:22:38.764Z  WARN 1 --- [http-nio-25600-exec-79] .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Cannot deserialize value of type `java.time.LocalDate` from String "999-12-31": Failed to deserialize java.time.LocalDate: (java.time.format.DateTimeParseException) Text '999-12-31' could not be parsed at index 0]

Komga version

v1.19.1-master

Operating system

Arch Linux

Installation method

Docker

Other details

No response

Acknowledgements

  • I have searched the existing issues (open AND closed) and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@Eskuero Eskuero added the triage label Feb 8, 2025
@Eskuero
Copy link
Author

Eskuero commented Feb 8, 2025

From what I see HTML won't support BCE dates so I guess negatives would be a pain, still less 1000 would be nice

@gotson
Copy link
Owner

gotson commented Feb 10, 2025

i doubt you would have books published before year 1000 though, no?

@gotson
Copy link
Owner

gotson commented Feb 10, 2025

You need to make sure the leading zeros are present:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants