Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

New check: Linkit shouldn't be configured to output 'Direct file link' #19

Open
rooby opened this issue Apr 6, 2018 · 1 comment
Open

Comments

@rooby
Copy link

rooby commented Apr 6, 2018

Due to the dynamic nature of the files directory it is not a good idea to link direct to files with /sites/default/files/etc paths.

If you configure Linkit for file entities so that URL type is 'URL type' or 'Download file link' then you are going to end up with those direct file paths in your content, which may later break.

It would be good to raise a notice about this setting if it is configured in a potentially risky way.

govcms-linkit_file_settings

@tobybellwood
Copy link

Thanks @rooby - we've just discussed this and a first step would be for us to capture and report any site using direct/download file links that aren't "their own".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants