Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV_MODE might turn off google analytics in prod #29

Open
simesy opened this issue Dec 15, 2019 · 4 comments
Open

DEV_MODE might turn off google analytics in prod #29

simesy opened this issue Dec 15, 2019 · 4 comments

Comments

@simesy
Copy link
Contributor

simesy commented Dec 15, 2019

Adding tests for drupal settings, I notice that DEV_MODE may cause undesireable development settings to load in a production environment. This would turn off google analytics. Probably minor but I wanted capture it while i noticed it.

@simesy
Copy link
Contributor Author

simesy commented Dec 15, 2019

Probably more to the point, it would be good to add a bats test around settings that should persist on prod in dev mode.

@grahamethompson
Copy link

if DEV_MODE is enabled it also adds theme suggestions to markup in production.

And enables XDEBUG?

@simesy
Copy link
Contributor Author

simesy commented Jul 24, 2020

Is that what you're seeing @thompsong ?

@grahamethompson
Copy link

Not sure about the XDebug, but definitely seeing theme debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants