Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for circular dependencies #2

Open
smkhalsa opened this issue Aug 24, 2020 · 4 comments
Open

Add support for circular dependencies #2

smkhalsa opened this issue Aug 24, 2020 · 4 comments

Comments

@smkhalsa
Copy link
Member

currently, I get the following error

Unhandled exception:
NoSuchMethodError: The getter 'reversed' was called on null.
Receiver: null
Tried calling: reversed
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      main (file:///Users/smkhalsa/.pub-cache/hosted/pub.dartlang.org/multipack-0.1.3/bin/multipack.dart:10:69)
<asynchronous suspension>
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

when running multipack pubspec override if I have a circular dependency.

@smkhalsa
Copy link
Member Author

@klavs do you have any insight on this?

@klavs
Copy link
Contributor

klavs commented Sep 27, 2020

I do not know how to universally handle circular dependencies in a directed graph. I'd imagine user would have to define how to break the cycle so that we can figure out what's the topological order.

I think lerna handles circular dependencies, there might be hints in their source code.

@huang12zheng
Copy link

https://github.com/huang12zheng/multipack

I just had done a test with multipack pubspec override

  • test workflow
# step1
# file /Users/huangzheng/.pub-cache/bin/multipack
# change to
dart "/Users/huangzheng/frontend/multipack/bin/multipack.dart" "$@"
# step2
run `multipack pubspec override` in ferry

@huang12zheng
Copy link

And, I don't know how to deal with InfoCommand

This was referenced Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants