Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow action, wrapper and testKit to share downloaded Gradle distributions #22

Closed
bigdaz opened this issue Aug 20, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@bigdaz
Copy link
Member

bigdaz commented Aug 20, 2023

Currently, there are 3 mechanisms by which Gradle distributions may be downloaded:

  1. When the gradle-build-action provisions a specified Gradle version for use
  2. When the Gradle wrapper is used to run a project
  3. When Gradle TestKit is used to test a project with different Gradle versions.

Ideally, these would all share a common download location and cache entry, avoiding the need to re-download the same Gradle distribution multiple times.

In addition, if a Gradle distribution is pre-installed on the runner, it would be good if this version didn't have to be re-downloaded for the 3 mechanisms listed above.

@bigdaz
Copy link
Member Author

bigdaz commented Aug 20, 2023

This comment indicates that TestKit downloads are not being properly cached, exacerbating the issue.

@bigdaz bigdaz added the enhancement New feature or request label Jan 8, 2024
@bigdaz bigdaz transferred this issue from gradle/gradle-build-action Feb 9, 2024
@bigdaz
Copy link
Member Author

bigdaz commented Jan 24, 2025

Reused of wrapper distributions in TestKit is beyond the scope of this action. This should be implemented in Gradle.

The action already attempts to reuse a wrapper distribution for cache cleanup. I think this is sufficient.

@bigdaz bigdaz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant