-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if wrapper matches the version specified in properties #282
Comments
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
I assume this also has another security advantage: Currently the checksum is allowed to match any of the checksums of the 200+1 versions. This likely makes it easier (but it is still difficult) to create a malicious JAR which has a hash collision with any of the 200+ possible checksums, than causing a hash collision with a single checksum. Footnotes
|
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
You could update the Gradle version in the properties but forget to update the wrapper too.
This could also be a (theoretically) security risk by checking-in a valid but outdated wrapper which could have vulnerabilities.
The text was updated successfully, but these errors were encountered: