Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to update watched directories #233

Open
lptr opened this issue Jul 2, 2020 · 0 comments
Open

API to update watched directories #233

lptr opened this issue Jul 2, 2020 · 0 comments

Comments

@lptr
Copy link
Member

lptr commented Jul 2, 2020

Instead of FileWatcher.startWatching() / stopWatching() we could also have an API to updateWatching() that would simply overwrite the set of watched directories.

Say, we are currently watching ["/usr/local", "/usr/bin"] and we want to watch ["/usr/bin", "/opt"] instead. With the existing APIs the transition requires the client code to diff the two sets and issue two calls:

watcher.stopWatching([new File("/usr/local")])
watcher.startWatching([new File("/opt")])

Instead, it could do the following single call:

watcher.updateWatching([new File("/usr/bin"), new File("/opt")])
@lptr lptr added the @execution label Jul 2, 2020
@lptr lptr removed the @execution label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant