Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing panel types for timeseries and state-timeline #178

Open
andreasjansson opened this issue Oct 25, 2021 · 2 comments
Open

Missing panel types for timeseries and state-timeline #178

andreasjansson opened this issue Oct 25, 2021 · 2 comments

Comments

@andreasjansson
Copy link

When running cortextool analyse grafana (as desribed here) the panels on my dashboard came back empty in the metrics-in-grafana.json output.

I traced it down to this library which is vendored into grafana/cortex-tools. All my panels are of type "timeseries" and "state-timeline", which aren't implemented in sdk/panel.go.

@andreasjansson
Copy link
Author

The following patch made cortextool work, but It's incomplete so I'm hesitant to submit a PR since I don't know the rest of the code base: https://gist.github.com/andreasjansson/dad1a3efea7d7643838c962d65740e20

@GiedriusS
Copy link
Collaborator

That looks great, just needs some extra tests in https://github.com/grafana-tools/sdk/blob/master/board_visual_test.go and/or https://github.com/grafana-tools/sdk/blob/master/rest-dashboard_integration_test.go. From which version have these panels appeared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants