Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 : Group vs GroupBy #184

Open
kevitan opened this issue Nov 24, 2021 · 0 comments
Open

🐛 : Group vs GroupBy #184

kevitan opened this issue Nov 24, 2021 · 0 comments

Comments

@kevitan
Copy link
Contributor

kevitan commented Nov 24, 2021 •
edited
Loading

My recent pull request (#180) modified the Target.GroupBy field to be singular, but as it happens, what I needed was to change the Target.Group to Target.GroupBy. At least in Grafana 8, the schema for Target.GroupBy should be what the SDK currently defines as the schema for Target.Group - is there any major issue with merging the two, or at least having identical schema declarations for them?
@kevitan kevitan changed the title Group vs GroupBy 🐛 : Group vs GroupBy Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevitan