Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate top-level service selection #1684

Open
marctc opened this issue Feb 20, 2025 · 1 comment
Open

Deprecate top-level service selection #1684

marctc opened this issue Feb 20, 2025 · 1 comment
Labels
documentation Improvements or additions to documentation tech-debt

Comments

@marctc
Copy link
Contributor

marctc commented Feb 20, 2025

We currently have two ways of service selection: top-level configuration (with fields like executable_name or open_port)
and using discovery > services section.

This causes some confusion as it not clear the rules of how filters are applied (see #1683) neither is documented.

We should indicate in the code a deprecation policy, and potentially remove it from the config in futures versions.

Remove it from docs. Places like service discovery docs or global properties are documenting these fields.

@marctc marctc added tech-debt documentation Improvements or additions to documentation labels Feb 20, 2025
@marctc
Copy link
Contributor Author

marctc commented Feb 21, 2025

related #1206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tech-debt
Projects
None yet
Development

No branches or pull requests

1 participant