You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently, #342 migrated packages from weaveworks/common to dskit.
One of the changes was to replaced the use of prometheus with promauto which in cases of downstream users who try to instantiate multiple instances of objects (eg. due to configuration reloads) triggers "duplicate metrics collector registration attempted" panics, for example here and here.
We should allow downstream consumers of packages to pass in their own Prometheus registerers for these metrics, or default to the global one if nil is passed.
The text was updated successfully, but these errors were encountered:
Recently, #342 migrated packages from weaveworks/common to dskit.
One of the changes was to
replaced the use of prometheus with promauto
which in cases of downstream users who try to instantiate multiple instances of objects (eg. due to configuration reloads) triggers "duplicate metrics collector registration attempted" panics, for example here and here.We should allow downstream consumers of packages to pass in their own Prometheus registerers for these metrics, or default to the global one if
nil
is passed.The text was updated successfully, but these errors were encountered: