Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken; also there is no linting for the changelog #316

Open
felixfontein opened this issue Jan 28, 2025 · 1 comment
Open

CI is broken; also there is no linting for the changelog #316

felixfontein opened this issue Jan 28, 2025 · 1 comment

Comments

@felixfontein
Copy link

Currently CI seems to be broken and should be fixed.

Also it looks like changelogs/changelog.yaml is edited manually instead of using changelog fragments, and no linting is run on the results. Running antsibull-changelog lint-changelog-yaml changelogs/changelog.yaml produces a list of problems:

changelogs/changelog.yaml:0:0: 'releases' -> '4.0.0' -> 'changes': section "minor_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.1.0' -> 'changes': section "major_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.3.0' -> 'changes': section "major_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.4.0' -> 'changes': section "major_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.4.1' -> 'changes': section "major_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.5.0' -> 'changes': section "major_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.5.1' -> 'changes': section "bugfixes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.5.1' -> 'release_date' is expected to be <class 'str'>, but got None
changelogs/changelog.yaml:0:0: 'releases' -> '5.6.0' -> 'release_date' is expected to be <class 'str'>, but got None
changelogs/changelog.yaml:0:0: 'releases' -> '5.7.0' -> 'changes': (WARNING/2) Inline emphasis start-string without end-string.
changelogs/changelog.yaml:0:0: 'releases' -> '5.7.0' -> 'changes': section "major_changes" list items must be type str not dict
changelogs/changelog.yaml:0:0: 'releases' -> '5.7.0' -> 'release_date' is expected to be <class 'str'>, but got None

If you manually edit changelogs/changelog.yaml, please carefully study the specifications (https://ansible.readthedocs.io/projects/antsibull-changelog/changelog.yaml-format/) and use the linter to verify that everything looks good from a technical point of view.

@ishanjainn
Copy link
Member

Thanks @felixfontein will get this fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants