Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Include cache entry timestamp in trace events emitted by postings for matchers cache" #823

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

charleskorn
Copy link
Contributor

Reverts #820

@pracucci pointed out in grafana/mimir#10467 (comment) that this may make the cache ineffective in the case where computing the postings takes a long time.

@charleskorn charleskorn enabled auto-merge January 19, 2025 22:22
@charleskorn charleskorn merged commit a49debd into main Jan 20, 2025
8 checks passed
@charleskorn charleskorn deleted the revert-820-charleskorn/pfmc-span-logging branch January 20, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants