Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize e2e tests #3217

Closed
joeyorlando opened this issue Oct 30, 2023 · 0 comments
Closed

Stabilize e2e tests #3217

joeyorlando opened this issue Oct 30, 2023 · 0 comments
Assignees
@brojd
Labels
bug Something isn't working more info needed

Comments

@joeyorlando
Copy link
Contributor

What went wrong?

What happened:

What did you expect to happen:

  • The tests should pass reliably

How do we reproduce it?

Run the direct paging e2e tests several times, they will likely fail at least once.

Grafana OnCall Version

v1.3.48

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@joeyorlando joeyorlando added the bug Something isn't working label Oct 30, 2023
@joeyorlando joeyorlando self-assigned this Oct 30, 2023
@joeyorlando joeyorlando removed their assignment Oct 31, 2023
@brojd brojd self-assigned this Nov 14, 2023
@brojd brojd changed the title Flaky direct-paging e2e tests Stabilize e2e tests Nov 16, 2023
@brojd brojd mentioned this issue Nov 16, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 17, 2023
@brojd
stabilize e2e tests (#3349)
45ae040 
# What this PR does
Stabilize e2e tests by:
- improve usage of locators
- fix unreliable selectors
- prevent parallelism within the same test file

Additionally:
- configure eslint for e2e tests and fix existing errors/warnings
- bump Playwright version to latest stable

## Which issue(s) this PR fixes
#3217

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brojd brojd

Labels
bug Something isn't working more info needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeyorlando @brojd