Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS] SLACK_INSTALL_RETURN_REDIRECT_HOST does not respect port info #5350

Closed
FecoDoo opened this issue Dec 9, 2024 · 1 comment
Closed
Labels
bug Something isn't working part:chatops

Comments

@FecoDoo
Copy link

FecoDoo commented Dec 9, 2024

What went wrong?

What happened:

The final value of SLACK_INSTALL_RETURN_REDIRECT_HOST does not inherit port number which is defined with its associated environment variable, which eventually leads to a 404 not found error due to mis-redirecting when trying to activate the Slack IRM integration in Grafana OnCall plugin:

https://<domain>/api/internal/v1/complete/slack-install-free/?slack_login_token=<dedacted>&code=<dedacted>&state=

What did you expect to happen:

Respect the full string of SLACK_INSTALL_RETURN_REDIRECT_HOST environment variable under https:///a/grafana-oncall-app/settings?tab=EnvVariables.

How do we reproduce it?

  1. Setup Grafana OSS and Grafana OnCall OSS
  2. Define env variable SLACK_INSTALL_RETURN_REDIRECT_HOST as https://fqdn:8080
  3. Open Grafana OnCall plugin and install Slack IRM integration
  4. Wait for redirecting back to https://fqdn/api/internal/v1/complete/slack-install-free/?slack_login_token=&code=&state= with a 404 error

Grafana OnCall Version

v1.13.6

Product Area

Chatops

Grafana OnCall Platform?

Other

User's Browser?

MS Edge

Anything else to add?

No response

@FecoDoo FecoDoo added the bug Something isn't working label Dec 9, 2024
@FecoDoo
Copy link
Author

FecoDoo commented Dec 10, 2024

Never mind, turns out to be a cache issue, re-deploying oncall engine and DB migration fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working part:chatops
Projects
None yet
Development

No branches or pull requests

1 participant