Feat: Bundle size action #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
requested review from
sunker,
wbrowne,
andresmgot and
xnyo
and removed request for
a team
jackw
force-pushed
the
jackw/bundle-size-action
branch
from
f800513 to
10007d4
Compare
academo
reviewed
Nov 14, 2024
|
|
||
| 1. Replace the frontend build command so on pushes to main the stats.json file is generated by webpack: | ||
|
|
||
| ```diff |
There was a problem hiding this comment.
which file is this? maybe let's use the one we use in our create-plugin template as example?
There was a problem hiding this comment.
I've updated the readme to mention file paths with the assumption that we're using create-plugin workflows.
academo
reviewed
Nov 14, 2024
academo
reviewed
Nov 14, 2024
academo
reviewed
Nov 14, 2024
academo
approved these changes
Nov 14, 2024
…multiple are returned by api
jackw
force-pushed
the
jackw/bundle-size-action
branch
from
0f14d2f to
68bdead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new action to surface frontend bundle size changes. It relies on the Github actions asset storage to track stats on the default branch. PRs will trigger stats builds and the actions script then compares the changes to asset and module sizes and if the total entrypoint difference is above the minimum threshold the action will post a comment on the PR with a breakdown. Various example comments using this action can be found here.
A standard comment where the size change of entrypoints is greater than the threshold can be seen here.
A similar comment that reduces size of entrypoints can be seen here.
A comment where a PR was previously above the minimum threshold but later falls within it can be seen here. I'm open to the idea of deleting it entirely as well but thought this more informative. 🤷