Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Knip to understand dependency usage #1360

Merged
merged 17 commits into from
Nov 29, 2024
Merged

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Nov 27, 2024

What this PR does / why we need it:
Adds a step to the CI workflow that uses knip to better understand which dependencies in scaffolded plugins are redundant.

Which issue(s) this PR fixes:

Related grafana/grafana-plugin-examples/issues/435

Special notes for your reviewer:

@jackw jackw added no-changelog Don't include in changelog and version calculations ci labels Nov 27, 2024
@jackw jackw self-assigned this Nov 27, 2024
@jackw jackw requested a review from a team as a code owner November 27, 2024 11:23
@jackw jackw requested a review from mckn November 27, 2024 11:23
Copy link

github-actions bot commented Nov 27, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me :)

Copy link
Collaborator

@tolzhabayev tolzhabayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jackw jackw merged commit 086586e into main Nov 29, 2024
12 checks passed
@jackw jackw deleted the jackw/frontend-knip-reports branch November 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci no-changelog Don't include in changelog and version calculations
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

4 participants