From 9f173f24cfae6cdad18cc48fa171336065cccf2a Mon Sep 17 00:00:00 2001 From: Jennie Pham <94262131+ie-pham@users.noreply.github.com> Date: Fri, 13 Sep 2024 15:16:30 -0500 Subject: [PATCH] Remove requiring github token for vendor-check (#4082) * do we need the token? * will this fix drone --- .drone/drone.yml | 26 ++++++++++++++++++++++++-- .github/workflows/ci.yml | 10 ---------- 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/.drone/drone.yml b/.drone/drone.yml index 358625498c4..c6ab62a2ce6 100644 --- a/.drone/drone.yml +++ b/.drone/drone.yml @@ -358,8 +358,12 @@ steps: } ] } - github_token: - from_secret: gh_token + github_app_id: + rom_secret: tempo-app-id + github_app_installation_id: + from_secret: tempo-app-installation-id + github_app_private_key: + from_secret: tempo-app-private-key trigger: ref: - refs/heads/main @@ -564,6 +568,24 @@ get: kind: secret name: gpg_passphrase --- +get: + name: tempo-app-id + path: ci/data/repo/grafana/tempo/github-app +kind: secret +name: app-id +--- +get: + name: tempo-app-installation-id + path: ci/data/repo/grafana/tempo/github-app +kind: secret +name: app-installation-id +--- +get: + name: tempo-app-private-key + path: ci/data/repo/grafana/tempo/github-app +kind: secret +name: app-private-key +--- kind: signature hmac: bee5601dffa0f46559f5d8734ebda1261ec9171a3dca7add1a23188f6f162945 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index be5d4cc2d91..6d8226353f1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -129,14 +129,6 @@ jobs: name: Vendor check runs-on: ubuntu-latest steps: - - name: Get app token - uses: actions/create-github-app-token@v1 - id: get-github-app-token - with: - app-id: ${{secrets.APP_ID}} - private-key: ${{secrets.APP_PRIVATE_KEY}} - owner: ${{github.repository_owner}} - - name: Check out code uses: actions/checkout@v4 @@ -147,8 +139,6 @@ jobs: - name: Install Protoc uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ steps.get-github-app-token.outputs.token }} - name: Check vendor run: make vendor-check