Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange voice selection handling #97

Open
lumpidu opened this issue Apr 29, 2022 · 0 comments
Open

Rearrange voice selection handling #97

lumpidu opened this issue Apr 29, 2022 · 0 comments
Assignees
Labels
2.0.x bug Something isn't working

Comments

@lumpidu
Copy link
Collaborator

lumpidu commented Apr 29, 2022

Currently, we return many voices for the Icelandic locale, "abducting" the locale property variant for the voice name. The user has to explictely choose the voice by selecting the locale, instead of choosing it via the voice settings.

We should rather make the voice choosable inside the app and only return the selected voice for the "favorite" voice of is_IS. If the user presses the voice settings inside the TTS system settings, we should refer him to these settings. We should only add more voices for the locale, if we really support different locales.

@lumpidu lumpidu self-assigned this Apr 29, 2022
@lumpidu lumpidu added the bug Something isn't working label Apr 29, 2022
@lumpidu lumpidu added the 1.3.x label Oct 13, 2022
@lumpidu lumpidu added 2.0.x and removed 1.3.x labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.x bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant