V2.0.x #161
Merged
V2.0.x #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firebase Crashlytivs shows exceptions for upgraded Apps from v1.3.x => V2.0.x. The reason is that existing voices in the DB are invalid in the new App. We also see that some columns inside app_data_table are obsoleted and adapt the schema accordingly. - Fix the database by removing all voice entries that are not of type onnx - Remove unnecessary columns in app_data_table - Add all schemas from 1..8 to version control - Add test case for migrations from schema version 7..8 - Fix existing tests to set correct schema_version when creating table app_data_table Signed-off-by: Daniel Schnell <[email protected]>
In case where the voice_table is empty, an update of the column current_voice_id wouldn't be possible in combination with the NON NULL constraint. Take this case into account and set the value then to -1. User code has to handle that scenario that basically means: no voice is currently selected. Currently there is no user code dependend on this. Add an appropriate migration test. Signed-off-by: Daniel Schnell <[email protected]>
Fix exceptions for old voices in DB when upgrading to App version 2.0.x
Set default value to current database schema by introducing constructor inside the AppData class. This also initializes other properties like currentVoiceId, privacyInfoDialogAccepted, crashLyticsUserConsentGiven and moves implicit initialization away from the declaration into the constructor. Not using the annotation for a Db level default value, as this would change the database schema again. These changes are only relevant for a fresh database after a new installation. Signed-off-by: Daniel Schnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.