feat: new StorageAdapter interface #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
roziscoding
commented
Jun 26, 2023
roziscoding
commented
Jun 26, 2023
|
There is any change that need to be done to get this merged? |
|
Unsure. It needs to be tested thoroughly by someone, and then refined as necessary. Could you do that? |
|
I'll close this for now. In case anyone feels like picking it up, they can just clone the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates the new
StorageAdapterinterface, which uses "cascading keys" in the style used by Deno KV, which allows us to essentially have the idea of a "collection" in the storage adapter.Now, we can store not only chat members, but also chats and users separately, allowing for a cached
getChatmethod, as well as for the existance of agetUsermethod. Besides that, it is now possible to get a list of all known chats, users, and chat members usingget<object>Listfunctions.