Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retrying getFile requests upon empty file paths #689

Open
Tracked by #675
KnorpelSenf opened this issue Dec 15, 2024 · 4 comments
Open
Tracked by #675

feat: retrying getFile requests upon empty file paths #689

KnorpelSenf opened this issue Dec 15, 2024 · 4 comments
Assignees
@wojpawlik

Comments

@KnorpelSenf
Copy link
Member

This is the only correct way of handling this case. The auto-retry plugin or the files plugin should take care of this. They should then also adjust the return type of the method and guarantee file_path to be present.
@KnorpelSenf KnorpelSenf mentioned this issue Dec 15, 2024
Open
51 tasks
@wojpawlik
Copy link
Contributor

Would fit neatly into auto-retry, if not for type adjustment... The type is technically correct.

@KnorpelSenf

This comment was marked as resolved.

Sign in to view
@wojpawlik
Copy link
Contributor

file_path being optional is technically correct even if we guarantee it's present.

@KnorpelSenf
Copy link
Member Author

No it's not, the point is to retry getFile until we get a file path back

@wojpawlik wojpawlik self-assigned this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wojpawlik wojpawlik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KnorpelSenf @wojpawlik