use a shallow copy of the points in json wrapper, closes #42

granny · May 13, 2024 · 36cfdf4 · 36cfdf4
1 parent ad5749f
commit 36cfdf4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/core/src/main/java/net/pl3x/map/core/markers/marker/Polyline.java b/core/src/main/java/net/pl3x/map/core/markers/marker/Polyline.java
@@ -172,9 +172,9 @@ public Polyline(@NotNull String key, @NotNull Collection<@NotNull Point> points)
      * @return this line
      */
     public @NotNull Polyline loop() {
-        Preconditions.checkState(this.points.size() > 0, "No points to loop back on");
-        Point first = this.points.get(0);
-        Point last = this.points.get(this.points.size() - 1);
+        Preconditions.checkState(!this.points.isEmpty(), "No points to loop back on");
+        Point first = this.points.getFirst();
+        Point last = this.points.getLast();
         Preconditions.checkState(!first.equals(last), "First and last points are the same");
         this.points.add(first);
         return this;
@@ -269,7 +269,7 @@ public Polyline(@NotNull String key, @NotNull Collection<@NotNull Point> points)
     public @NotNull JsonObject toJson() {
         JsonObjectWrapper wrapper = new JsonObjectWrapper();
         wrapper.addProperty("key", getKey());
-        wrapper.addProperty("points", getPoints());
+        wrapper.addProperty("points", new ArrayList<>(getPoints()));
         wrapper.addProperty("pane", getPane());
         return wrapper.getJsonObject();
     }