Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle >30 day -since #16

Open
graphaelli opened this issue May 7, 2020 · 0 comments
Open

Handle >30 day -since #16

graphaelli opened this issue May 7, 2020 · 0 comments

Comments

@graphaelli
Copy link
Owner

It seems that using from > 30 days ago in:

zat/zoom/zoom.go

Lines 252 to 269 in d93387a

func (c *Client) ListRecordings(since time.Time, nextPageToken string) (*ListRecordingsResponse, error) {
var j ListRecordingsResponse
req, err := c.NewApiRequest(http.MethodGet, "v2/users/me/recordings")
if err != nil {
return nil, fmt.Errorf("while building ListRecordings request: %w", err)
}
v := req.URL.Query()
v.Set("from", since.Format(timeQuery))
v.Set("page_size", "300") // max
if nextPageToken != "" {
v.Set("next_page_token", nextPageToken)
}
req.URL.RawQuery = v.Encode()
if _, err := c.Do(req, &j); err != nil {
return nil, fmt.Errorf("while executing ListRecordings request: %w", err)
}
return &j, nil
}

results in zoom returning only recordings from the last 30 days. This isn't mentioned in the api docs but could be worked around by breaking up the requests into 30 days chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant