Fast path if view is not stable?

[lemmy]

The comment suggests tha the the negation of ctx.view_is_stable... is incorrect.

pirateship/src/consensus/steady_state.rs

Lines 276 to 283 in 98a4f46

	#[cfg(feature = "fast_path")]
	if !ctx.view_is_stable.load(Ordering::SeqCst) {
	// Fast path can't be done if the view is not stable.
	debug!("For fast path: {} {}", fullnode_sigs, get_all_nodes_num(&ctx));
	if fullnode_sigs == get_all_nodes_num(&ctx) as usize {
	fast_path_qcs.push(vote_sig.n);
	}
	}

[grapheo12]

Thanks for finding this.
I think it doesn't matter in the steady state because maybe_byzantine_commit() checks for fast path QCs regardless of this block of code.