-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change special return value for REMOVE #96
Comments
Maybe we should create an enum Would that solve the problem? |
That would work! Arguably it would work even better because we wouldn't need to update the type-hint every time we have a visitor function return a different special value. |
I have implemented this in the master branch now. |
The
visitor.py
file sets the special valueREMOVE
toEllipsis
. However, this causes trouble with type-hinting functions that return REMOVE. Could we create a separate value rather than usingEllipsis
? See the issues linked here, where the consensus is in favor of not using theEllipsis
constant. Thank you!The text was updated successfully, but these errors were encountered: