incremental: introduce GraphQLWrappedResult to avoid filtering #4026
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
take-two
branch
2 times, most recently
from
5c12269
to
2665ebd
Compare
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
yaacovCR
force-pushed
the
take-two
branch
2 times, most recently
from
522b53a
to
5644ddf
Compare
yaacovCR
added
the
PR: polish 💅
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
This comment has been minimized.
This comment has been minimized.
yaacovCR
changed the title
yaacovCR
changed the title
|
reposting benchmarks considering there were a few changes
alpha-1 is prior to incremental delivery, current-main is basically alpha-3, and we see that the rewrite improves on it significantly in the synchronous list case. the next set of PRs should hopefully improve further. we can then judge whether we should/want to bring back a form of filtering. |
in the non-deferred case. depends on #4026 --------- Co-authored-by: Rob Richard <[email protected]>
Test logic was inadvertently altered in graphql#4026. Tests still pass, just fixing logic.
Test logic was inadvertently altered in #4026. Tests still pass, just fixing logic.
following graphql/graphql-spec#1077
now part of the following PR stack, with the laters PRs extracted from this one
#4026: incremental: introduce GraphQLWrappedResult to avoid filtering
#4050: perf: allow skipping of field plan generation
#4051: perf: introduce completePromisedListItemValue
#4052: refactor: introduce completeIterableValue
#4053: perf: optimize completion loops
#4046: perf: use undefined for empty