Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fixthemap to remove javascript and add tests #257

Open
gravitystorm opened this issue Feb 27, 2023 · 0 comments
Open

Refactor fixthemap to remove javascript and add tests #257

gravitystorm opened this issue Feb 27, 2023 · 0 comments

Comments

@gravitystorm
Copy link
Owner

There's a feature on the fixthemap page that means you can link to it like this:

https://www.openstreetmap.org/fixthemap?lat=47.21776092401608&lon=8.524017333984375&zoom=13

... and the note icon will then get a link to the right place on the map. This is done by javascript after the page has loaded.

But the controller has access to this information too, and it can rework it and pass it to the view, so there's no need for it to be in javascript. So let's refactor it, since building links in javascript on pageload is quite unexpected.

It could also do with a test, since third-party pages rely on it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant