Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework notes to have a body and author #6

Open
gravitystorm opened this issue Oct 6, 2016 · 0 comments
Open

rework notes to have a body and author #6

gravitystorm opened this issue Oct 6, 2016 · 0 comments

Comments

@gravitystorm
Copy link
Owner

The current system is to have notes, and create a comment when the note is created. This is fiddly, and leaves e.g. the tests convoluted and lots of hidden dependencies throughout the app code expecting that first comment.

It would make more sense for the note to have a body, instead of implied necessity of the initial comment. I've no idea why it wasn't like this to start.

There's also weirdness around the note having no user_id, but instead the note.author coming from note.comments.first.author. Given the first comment is again treated as something special, the ownership of the note should be on the note itself.

However, cleaning this up would involve a hairy migration, to convert the contents of the first comment on every note into attributes of the note itself. So it's not a high priority.

@gravitystorm gravitystorm changed the title rework notes to have a body rework notes to have a body and author Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant