Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of gem with Ruby 2.4.x support #61

Closed
Kitton opened this issue Aug 28, 2017 · 24 comments
Closed

New version of gem with Ruby 2.4.x support #61

Kitton opened this issue Aug 28, 2017 · 24 comments

Comments

@Kitton
Copy link

Kitton commented Aug 28, 2017

It will be really nice to release a new version of gem with the latest commits included (#55).

@goya
Copy link

goya commented Sep 30, 2017

i hereby support this issue.

@tboyko
Copy link

tboyko commented Dec 12, 2017

@milgner Are you able to release a 3.0.1 or 3.1.0 of the gem? We'd like to eliminate the numerous warnings that this gem is currently producing in our environments.

@tboyko
Copy link

tboyko commented Mar 12, 2018

@tessie Can you assist with this?

@vad1m
Copy link

vad1m commented Apr 5, 2018

@joschi could you please help?

@joschi
Copy link
Contributor

joschi commented Apr 6, 2018

@milgner and @tessie are the maintainers of this project and they can create a release if they think it's ready.

@milgner
Copy link
Contributor

milgner commented Apr 6, 2018

After merging many changes, I'd have liked to run the current master in a staging environment for a bit, logging to a real system before releasing a new version. I'll give it a try today, if no immediate problems pop up, I'll create a release over the weekend.

@joschi
Copy link
Contributor

joschi commented Apr 6, 2018

@milgner Maybe the other commenters here in this issue can help with testing if you release a beta/release candidate.

@yuri1969
Copy link

@milgner, @tessie Is there a roadmap update regarding the 3.0.0+ release? Although many important PRs have been merged, we are still stuck with the almost 2 yo release. It'd be cool to have a fresh version available.

@tboyko
Copy link

tboyko commented Jun 11, 2018

@milgner Are you able to share with us how the tests went? Can we expect an updated release soon?

@tboyko
Copy link

tboyko commented Jun 13, 2018

Paging @edmundoa @jalogisch @joschi @lennartkoopmann @AlekSi @bernd @milgner

Apologies if this is considered poor etiquette, but we could really use some help/feedback here.

@milgner
Copy link
Contributor

milgner commented Jun 13, 2018

I haven't received any additional feedback and unfortunately the tests I could do were a bit limited. I propose releasing a version labeled RC1. This way, even if you don't want to point your Gemfile to Github, you can already use the new features from an official gem version.

@ghost
Copy link

ghost commented Jun 14, 2018

@milgner If you do that today, I can test it in a real environment today 👍 Desperately need this since we're just migrating some legacy code to newer Ruby+Rails.

@tessie
Copy link
Collaborator

tessie commented Jun 14, 2018

@milgner Do let me know if you need any help.

@milgner
Copy link
Contributor

milgner commented Jun 14, 2018

@alex-mohemian I pushed a new version tag this morning but so far it doesn't seem to have been picked up by the release automatism. Currently busy on my day job and don't know whether I'll find some time this evening.

@tessie if you could find some time to check out why pushing the tag did not result in a new version being published, that would be really great!

@tessie
Copy link
Collaborator

tessie commented Jun 15, 2018 via email

@ghost
Copy link

ghost commented Aug 30, 2018

@milgner is there a 3.1.0 release planned any time soon?

@milgner
Copy link
Contributor

milgner commented Aug 30, 2018

@alex-mohemian I did publish a tag for a release a couple of weeks ago but somehow it wasn't published correctly. I'll have to check the configuration again, something seems to be broken in the publishing process.

@ghost
Copy link

ghost commented Aug 30, 2018

@milgner the v3.1.0-rc.1 tag and subsequent gem is released correctly -- thank you for that. I was talking about a 3.1.0 GM/final/no-rc release 😉

@milgner
Copy link
Contributor

milgner commented Aug 30, 2018

@alex-mohemian ah, that is good to know. I was going by the information on rubygems.org which still shows 3.1.0.pre.rc.1 as the last version and so I thought that something was broken 😬
But seeing as no new issues have been opened since, I think we're good to go for a final release 🎉 I'll schedule it for the next couple of days 👍

@ghost
Copy link

ghost commented Aug 30, 2018

I'm sorry, my mistake. Yes, 3.1.0.pre.rc.1 is the last version on rubygems.org.

Looking forward for the 3.1 final :)

@ghost
Copy link

ghost commented Sep 4, 2018

@milgner Is there anything I could do to help you get the 3.1 out? 🙂

@milgner
Copy link
Contributor

milgner commented Sep 4, 2018

Since I'm not sure what the actual problem was, I'll go ahead and push another tag for 3.1 and see what happens. There might have been a problem with the version ordering among 3.1.0.pre.rc.1 and 3.1.0-rc.1 - but 3.1.0 might still work.
In case the release doesn't show up at rubygems.org, I'll have to contact the Graylog team as they originally set up the auto-release process and I don't have access to that part of the configuration. For now, let's cross our fingers and hope that it will work 🤞

@ghost
Copy link

ghost commented Sep 6, 2018

@milgner looks like it did work :) Rubygems picked it up! Thank you!

@milgner
Copy link
Contributor

milgner commented Sep 6, 2018

@alex-mohemian that's great to hear! I struggled a bit with the old jeweler version not being able to regularly bump the version. @tessie already prepared a dependency version bump in #66 but unfortunately new versions of jeweler break compatibility with old Rubies... 😬
Nonetheless, closing this issue for now, as 3.1 has been released successfully 😉

@milgner milgner closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants