Skip to content
This repository was archived by the owner on Jan 8, 2019. It is now read-only.

User names are case sensitive #1007

Open
askmeaks opened this issue Dec 16, 2014 · 9 comments
Open

User names are case sensitive #1007

askmeaks opened this issue Dec 16, 2014 · 9 comments

Comments

@askmeaks
Copy link

We have LDAP integration for Graylog for authentication, and when we log in using different cases, a new user is generated in the system. Graylog is creating new users for different character cases (e.g. askmeaks, ASKMEAKS, askMeaks etc. are all different users). User names should be case in-sensitive.

@runningman84
Copy link

+1

1 similar comment
@henrikjohansen
Copy link

+1

@kroepke kroepke added this to the 1.0.0 milestone Jan 14, 2015
@kroepke
Copy link
Contributor

kroepke commented Jan 14, 2015

The fix seems very simple, we should take the DN used by the bind action.
If the world is sane that will have a consistent case.

@kroepke kroepke self-assigned this Jan 14, 2015
@kroepke
Copy link
Contributor

kroepke commented Jan 14, 2015

In fact this is not simple to fix at all, but it seems the best option anyway.

We will create a migration command for existing users, but it is unlikely that we can automatically merge existing accounts.

@joschi
Copy link
Contributor

joschi commented Jan 14, 2015

We could/should add a configuration setting for this but I don't think usernames should be treated case-insensitive in general.

EDIT: The uid attribute is case-insensitive so this is why new users would be created with a different upper-/lowercase writing. But since people could use another attribute for retrieving user names from LDAP, I wouldn't like to hardcode this. Maybe an option (by default enabled) to lowercase user names before fetching them from LDAP would work.

kroepke added a commit to Graylog2/graylog2-server that referenced this issue Jan 14, 2015
avoid problems with case insensitive ldap users, where user accounts would be created for each login with different upper/lower-case combination

fixes graylog-labs/graylog2-web-interface#1007
@kroepke
Copy link
Contributor

kroepke commented Jan 14, 2015

If users with the same name are found during login (i.e. same letters but different case), an error will be logged during login and logging in will fail.
The administrator needs to clean up these accounts manually, there is no automatic way to merge this, so a migration tool does not make any sense.

@kroepke
Copy link
Contributor

kroepke commented Jan 14, 2015

In fact after debating the broken solution in the branch above, as well as some alternatives, this seems way too risky for 1.0.
Postponing it until we have found a proper way of dealing with this problem.

@kroepke kroepke modified the milestones: 1.1.0, 1.0.0 Jan 14, 2015
@kroepke kroepke removed this from the 1.1.0 milestone May 26, 2015
@kroepke
Copy link
Contributor

kroepke commented May 26, 2015

This will not make it into 1.1

@bernd bernd added the feature label Aug 11, 2015
@kroepke kroepke added this to the 2.x milestone Aug 24, 2015
@kroepke kroepke removed their assignment Oct 21, 2015
@jhaar
Copy link

jhaar commented Nov 18, 2015

+1. We seem to have people routinely log in using different case - and end up with different accounts. Really weird, even I have two accounts: "[email protected]" and "[email protected]" - and yet I can't recall ever logging in with the latter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants