Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC69] Method call in the third section of a for-loop #18

Open
fmunch opened this issue Feb 13, 2024 · 2 comments
Open

[EC69] Method call in the third section of a for-loop #18

fmunch opened this issue Feb 13, 2024 · 2 comments
Labels
🗃️ rule rule improvment or rule development or bug 🚀 enhancement New feature or request

Comments

@fmunch
Copy link

fmunch commented Feb 13, 2024

Describe the bug
EC69 flags method calls in the third section of a for-loop, even though these calls are legitimate.

Expected behavior
EC69 should not check the first and third sections of a for-loop, since these sections are dedicated to code execution before the first iteration and after each iteration respectively. The second section is probably the only one where code execution could often be executed only once instead of executed at each iteration.

Screenshots
ec69

Software Versions

  • SonarQube Version: 10.3
  • Plugin Version: 1.4.3
@dedece35
Copy link
Member

Hello @fmunch,
thank you for issue !
I'm ok with you !
First of all, we will improve EC69 rule for Java. We will see next if this improvment must be done for other language plugins.

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug 🚀 enhancement New feature or request labels Feb 16, 2024
@dedece35
Copy link
Member

dedece35 commented Mar 22, 2024

please take into account issue #21, maybe this rule is irrelevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug 🚀 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants