chore: rename rule keys ECXXX to the Green Code Initiative naming convention GCIXXX #75
+350
−334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedece35
requested changes
Dec 13, 2024
| @@ -0,0 +1,21 @@ | |||
| { | |||
There was a problem hiding this comment.
this file must be named "creedengo_way_profile.json" and check impact inside code where this file is mentionned
and the "name" property must also be updated
| @@ -43,11 +43,11 @@ public void foo2() { | |||
| System.err.println(e.getMessage()); | |||
| } finally { | |||
| if (fr) { | |||
| fr.close(); | |||
| org.close(); | |||
There was a problem hiding this comment.
why do you update this variable ?
but checking the code, I think this code doesn't compile because "fr" variable is not visible in finally block ... hum ... we have to check this wrong example code
dedece35
added
🏗️ refactoring
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning : will need a proper version for the new artifactorg.green-code-initiative:creedengo-rules-specificationsonce available on Maven Central.creedengo-rules-specifications set to 2.0.0, available in Maven Central