Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement drag&drop functionality in the import page #1

Open
Mohammad96Assaf opened this issue Oct 5, 2024 · 7 comments
Open

Implement drag&drop functionality in the import page #1

Mohammad96Assaf opened this issue Oct 5, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Mohammad96Assaf
Copy link

The import page currently allows users to manually select files through a file picker. To improve the user experience, we need to implement a drag & drop functionality that enables users to upload files by simply dragging them into the designated area on the page.

@doriengr
Copy link

doriengr commented Oct 5, 2024

We should put this issue on hold. As I updated your code yesterday I realised that your input field is not accessible to people who needs to use the keyboard due to disabilities. Thats why I changed the input field to the default input field of the browser. I do not know if the drag and drop functionality is that much needed.

@Mohammad96Assaf
Copy link
Author

Thanks for the new design, it looks good! I noticed that the text inside the input field ("Choose file" and "No file chosen") is still in English. The reason I originally used a custom style was to solve this localization issue, as I couldn't control the text in the default browser input.

Do you have any suggestions for how we can address this language problem while using the default input field?

@doriengr
Copy link

doriengr commented Oct 5, 2024

@Mohammad96Assaf the input is the default HTML input field. The language is in English because your Browser language is English. Switch that to german and everything is in german. I did not code it, that's how the Browser renderer works.

@Mohammad96Assaf
Copy link
Author

@doriengr, what I mean is that the language of the file selection field should depend on the language of the application, not the language of the browser.

@doriengr
Copy link

doriengr commented Oct 5, 2024

@doriengr, what I mean is that the language of the file selection field should depend on the language of the application, not the language of the browser.

But what is the problem with it? Maybe it will also be possible to add other languages in the future.

@Mohammad96Assaf
Copy link
Author

Whether in the future or now, we still need to adjust it so that we use the language of the application. The problem is, you can’t leave it as it is, with the language of the file selection field based on the browser’s language while the rest of the application is in German. In my opinion, we should either keep the previous adjustment or we find a solution for this. The application's language needs to be consistent. Thanks!

@doriengr
Copy link

doriengr commented Oct 5, 2024

@Mohammad96Assaf Yes, lets optimize the frontend of the Import file then accordingly to the Design 😊 but lets do it in Release 2. Its nothing Important yet.

@doriengr doriengr added the enhancement New feature or request label Oct 7, 2024
@xk0niR xk0niR transferred this issue from green-ecolution/green-ecolution-frontend Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants