-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: request edit_config_family_all alongside edit_config_family #3857
Merged
timopollmeier
merged 7 commits into
greenbone:main
from
mattmundell:concurrent-edit-config-family
Oct 31, 2023
Merged
Change: request edit_config_family_all alongside edit_config_family #3857
timopollmeier
merged 7 commits into
greenbone:main
from
mattmundell:concurrent-edit-config-family
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3857 +/- ##
==========================================
+ Coverage 59.94% 59.95% +0.01%
==========================================
Files 1022 1022
Lines 25125 25132 +7
Branches 7439 7439
==========================================
+ Hits 15061 15068 +7
Misses 9116 9116
Partials 948 948
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm guessing a bit with the test commit, but it seems to be correct. gsad side is ready to merge when this PR is accepted. |
timopollmeier
approved these changes
Oct 31, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When getting scan config data, run the new gsad cmd
edit_config_family_all
concurrently with the existingedit_config_family
cmd.Why
Each of these cmds calls a separate GMP GET_NVTS command, so they can run simultaneously to save time. This speeds up the config family edit dialog.
References
Requires greenbone/gsad/pull/146.