Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: request edit_config_family_all alongside edit_config_family #3857

Merged

Conversation

mattmundell
Copy link
Contributor

What

When getting scan config data, run the new gsad cmd edit_config_family_all concurrently with the existing edit_config_family cmd.

Why

Each of these cmds calls a separate GMP GET_NVTS command, so they can run simultaneously to save time. This speeds up the config family edit dialog.

References

Requires greenbone/gsad/pull/146.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #3857 (ca6f694) into main (0cc93c7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3857      +/-   ##
==========================================
+ Coverage   59.94%   59.95%   +0.01%     
==========================================
  Files        1022     1022              
  Lines       25125    25132       +7     
  Branches     7439     7439              
==========================================
+ Hits        15061    15068       +7     
  Misses       9116     9116              
  Partials      948      948              
Files Coverage Δ
src/gmp/commands/scanconfigs.js 91.83% <100.00%> (+0.25%) ⬆️
src/gmp/commands/testing.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattmundell
Copy link
Contributor Author

I'm guessing a bit with the test commit, but it seems to be correct.

gsad side is ready to merge when this PR is accepted.

@timopollmeier timopollmeier merged commit 5328e8c into greenbone:main Oct 31, 2023
13 checks passed
@mattmundell mattmundell deleted the concurrent-edit-config-family branch October 31, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants