-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add CVSS missing range (0.1-0.9) #3867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3867 +/- ##
==========================================
- Coverage 59.90% 59.90% -0.01%
==========================================
Files 1021 1021
Lines 25092 25098 +6
Branches 7424 7426 +2
==========================================
+ Hits 15032 15035 +3
- Misses 9112 9115 +3
Partials 948 948
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjoernricks
approved these changes
Sep 19, 2023
bjoernricks
force-pushed
the
GEA-266-fix-cvss-missing-range
branch
from
September 19, 2023 09:23
00f7878
to
5fde5a1
Compare
Hey @bjoernricks thanks for taking a look on this PR. We might need to wait on merging this one. I disabled auto-merge |
a-h-abdelsalam
force-pushed
the
GEA-266-fix-cvss-missing-range
branch
2 times, most recently
from
October 5, 2023 14:50
908501f
to
a8a65e1
Compare
- Fixed filter range for value 9 to exclude 10. - Fixed filter range for value 10 to be 10 instead of >10
timopollmeier
force-pushed
the
GEA-266-fix-cvss-missing-range
branch
from
October 9, 2023 09:22
a661c4f
to
1bbde69
Compare
timopollmeier
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The range (0.1-0.9) is now shown in the CVSS chart and the corresponding tooltip and filter are consistent with the range.
Fixed the filter ranges for severity values 9 and 10. Value 9 should exclude 10 and Value 10 filter should filter only for 10 and not for > 10.
Why
The CVSS range (0.1-0.9) was missing.
References
GEA-266