Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add CVSS missing range (0.1-0.9) #3867

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

a-h-abdelsalam
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam commented Sep 15, 2023

What

The range (0.1-0.9) is now shown in the CVSS chart and the corresponding tooltip and filter are consistent with the range.

Fixed the filter ranges for severity values 9 and 10. Value 9 should exclude 10 and Value 10 filter should filter only for 10 and not for > 10.

Why

The CVSS range (0.1-0.9) was missing.

References

GEA-266

@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner September 15, 2023 14:20
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Conventional Commits Report

Type Number
Bug Fixes 2

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #3867 (1bbde69) into main (396fc0b) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3867      +/-   ##
==========================================
- Coverage   59.90%   59.90%   -0.01%     
==========================================
  Files        1021     1021              
  Lines       25092    25098       +6     
  Branches     7424     7426       +2     
==========================================
+ Hits        15032    15035       +3     
- Misses       9112     9115       +3     
  Partials      948      948              
Files Coverage Δ
...b/components/dashboard/display/cvss/cvssdisplay.js 21.05% <0.00%> (+1.05%) ⬆️
...components/dashboard/display/cvss/cvsstransform.js 72.22% <40.00%> (-6.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bjoernricks bjoernricks force-pushed the GEA-266-fix-cvss-missing-range branch from 00f7878 to 5fde5a1 Compare September 19, 2023 09:23
@bjoernricks bjoernricks enabled auto-merge (rebase) September 19, 2023 09:25
@a-h-abdelsalam
Copy link
Contributor Author

Hey @bjoernricks thanks for taking a look on this PR. We might need to wait on merging this one. I disabled auto-merge

@a-h-abdelsalam a-h-abdelsalam marked this pull request as draft September 19, 2023 09:34
@a-h-abdelsalam a-h-abdelsalam force-pushed the GEA-266-fix-cvss-missing-range branch 2 times, most recently from 908501f to a8a65e1 Compare October 5, 2023 14:50
@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review October 9, 2023 09:18
- Fixed filter range for value 9 to exclude 10.
- Fixed filter range for value 10 to be 10 instead of >10
@timopollmeier timopollmeier force-pushed the GEA-266-fix-cvss-missing-range branch from a661c4f to 1bbde69 Compare October 9, 2023 09:22
@bjoernricks bjoernricks merged commit 3644aac into main Oct 9, 2023
11 of 13 checks passed
@bjoernricks bjoernricks deleted the GEA-266-fix-cvss-missing-range branch October 9, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants