Fix: Fix position of resources drop-down menu for tags #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3868 +/- ##
=======================================
Coverage 59.90% 59.90%
=======================================
Files 1021 1021
Lines 25089 25091 +2
Branches 7421 7424 +3
=======================================
+ Hits 15030 15032 +2
Misses 9111 9111
Partials 948 948
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjoernricks
reviewed
Sep 18, 2023
bjoernricks
approved these changes
Sep 19, 2023
a-h-abdelsalam
force-pushed
the
GEA-251-fix-adding-resources-to-tags
branch
from
2c02829 to
a519c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the position of the drop-down menu for adding resources to be based on the
ScrollableContentelement which has a maximum height.Why
The position of the drop-down menu to add more resources was set according to the element containing the current resources.
Therefore, having a large number of resources pushes down the drop-down menu until it disappears from the screen.
References
GEA-251