-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouping Feature #1441
base: master
Are you sure you want to change the base?
Grouping Feature #1441
Conversation
@patorjk Nice work! I love this feature so far. One thing I'd like to see is the ability to load with the groups already expanded. I tried passing Thoughts on this? |
I unfortunately haven't had much time recently. I've put together a beta npm release which can be installed here:
If anyone has any feedback let me know. Assuming everything is fine, I'll try and release 3.5.0 this coming week. Basic API is as follows:
|
@patorjk is there exist a way to set handle expand to whole group title row not just to expand arrow ? |
@patorjk I also noticed that when adding grouping to options there no block with an empty title ( text showing when data empty ) |
Many thanks @patorjk, looking great! The only feedback that I have is that we could consider indenting the first column of sub-rows as in DevExtreme: https://devexpress.github.io/devextreme-reactive/react/grid/demos/featured/tree-data/ |
Hi, I really appreciate it. Very clean and simple! My feedback actually is more a question... how grouping would works with a hierarchy data?
I wanna a table like this:
Thank you. |
pump, i really need this feature.. could you please merge? |
Agreed, this feature would be very useful. Please merge! |
A friendly bump! We're really (really) excited to add this to our new project. :-) |
Is there a way to add pagination ? |
Is this going to be merged?? |
Any updates on this? |
A nifty feature, would like to hear if help is needed or a merge is possible. |
I did a manual merge as I needed this feature in production a few weeks ago - feel free to use: https://github.com/goqa-dev/goqa-datatables |
Bump, would really like this feature to be merged - any updates? |
bump |
gonna have to migrate to a different library if this isn't merged |
//console.log('getGroupingData'); | ||
//console.log(grouping); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//console.log('getGroupingData'); | |
//console.log(grouping); |
|
||
if (!cols || cols.length === 0) return null; | ||
|
||
//console.dir(displayData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//console.dir(displayData); |
|
||
//console.dir(displayData); | ||
let groups = this.getGroups(grouping, cols, displayData, 1, []); | ||
//console.dir(groups); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//console.dir(groups); |
@@ -5,6 +5,7 @@ import MuiTableBody from '@material-ui/core/TableBody'; | |||
import TableBodyCell from './TableBodyCell'; | |||
import TableBodyRow from './TableBodyRow'; | |||
import TableSelectCell from './TableSelectCell'; | |||
import TableBodyRows from './TableBodyRows'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great abstraction.
Glad to hear it. This feature caused me to go to react-grid, but I will definitely come back to this library with this feature! |
Work in progress. At this moment this is more of a proof-of-concept than a fully fleshed out new feature. You can see the Grouping feature live at the below link by selecting the "Grouping" example (once the project has loaded):
https://codesandbox.io/s/github/gregnb/mui-datatables/tree/groupings
At the moment I'm taking cues from React Grid's Grouping feature: https://devexpress.github.io/devextreme-reactive/react/grid/docs/guides/grouping/
What's left to do:
This is a pretty big feature, so I want to get it right. Please let me know if you have any feedback.