ci: NO-JIRA install global nx for codespaces #11
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the GitHub Codespaces configuration to align it with the local development workflow by installing nx globally and updating the development environment setup.
- Added
.devcontainer/install.shto install pnpm and nx globally in Codespaces - Modified
.devcontainer/devcontainer.jsonto use the new install script and set bash as the default shell - Removed pnpm feature and replaced updateContentCommand with postCreateCommand in devcontainer.json
- Updated Vitest extension in the devcontainer configuration
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+3
to
+5
| pnpm bin -g | ||
| source /home/node/.bashrc | ||
| pnpm bin -g |
There was a problem hiding this comment.
style: Redundant pnpm bin -g calls, remove one
Comment on lines
+1
to
+6
| #!/bin/bash | ||
| curl -fsSL https://get.pnpm.io/install.sh | sh - | ||
| pnpm bin -g | ||
| source /home/node/.bashrc | ||
| pnpm bin -g | ||
| pnpm -g add nx |
There was a problem hiding this comment.
style: Add error handling and logging to improve script robustness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: install global nx for codespaces
📖 Description
add global nx to codespaces since that's the same way we run our commands locally