Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DX/DMI & ADX #64

Open
virtualritz opened this issue Jul 20, 2022 · 2 comments
Open

Add DX/DMI & ADX #64

virtualritz opened this issue Jul 20, 2022 · 2 comments

Comments

@virtualritz
Copy link

Requires DM-/DM+, DI-/DI+ first.

I started implementing all of them in my fork as I need them for the project I'm working on.
While they're all there now I haven't yet verified them and/or wrote tests.

I will update this issue and open a PR once that is done.

In the meantime I'm happy for feedback – just opening this issue so others can benefit/don't do work twice.

@SeanEClarke
Copy link

Is this complete? if so, would you mind going ahead and raising a PR? - i am trying to get a batch of PRs ready and see if we can get the TA crate updated

@virtualritz
Copy link
Author

I'm not comfortable submitting a PR until #70 is resolved.

In general, I think it would give users confidence if the original TA-lib test data was used to verify all indicators in ta-rs work as in the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants