Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridapMakie is no longer compatible with Makie 0.15 (and provably 0.13) #62

Closed
fverdugo opened this issue Oct 18, 2022 · 5 comments
Closed

Comments

@fverdugo
Copy link
Member

We need to change the compat section accordingly.

@hammy4815
Copy link
Contributor

Hi @fverdugo , I've been able to locally remove the compat section (M1 chip), update all dependencies, and use the recipes without any issues.

  [5789e2e9] FileIO v1.16.2
  [1a297f60] FillArrays v1.9.3
  [e9467ef8] GLMakie v0.9.6
  [5c1252a2] GeometryBasics v0.4.10
  [56d4f2e9] Gridap v0.17.23
  [ee78f7c6] Makie v0.20.5

Are there any issues that I overlooked? Otherwise, could we bump?

@hammy4815
Copy link
Contributor

Hi @fverdugo ,

I've updated again to the most recent dependencies:

  [5789e2e9] FileIO v1.16.2
  [1a297f60] FillArrays v1.9.3
  [e9467ef8] GLMakie v0.9.8
  [5c1252a2] GeometryBasics v0.4.10
  [56d4f2e9] Gridap v0.17.23
  [ee78f7c6] Makie v0.20.7

And I still seem to be able to build plots using the recipes without encountering any problems.

@fverdugo
Copy link
Member Author

Hi @hammy4815,

thanks for reporting.

can you modify the compat section (link below) with the new version numbers and then open a PR?

[compat]

@hammy4815
Copy link
Contributor

Sure, no problem @fverdugo . I just opened a PR.

@JordiManyer
Copy link
Member

Closed by PR #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants