Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridapMakie seems outdated #70

Closed
eschnett opened this issue Feb 17, 2024 · 4 comments
Closed

GridapMakie seems outdated #70

eschnett opened this issue Feb 17, 2024 · 4 comments

Comments

@eschnett
Copy link

GridapMakie's Project.toml declarations refer to quite old version of some packages (e.g. FillArrays, Makie, CairoMakie). In addition, trying to use it results in an error:

julia> using GridapMakie
Precompiling GridapMakie
        Info Given GridapMakie was explicitly requested, output will be shown live
ERROR: LoadError: UndefVarError: `point_iterator` not defined

(This is with Julia 1.10.)

@rveltz
Copy link

rveltz commented Aug 21, 2024

Hi,

I have tried to solve it myself but did not succeed. Can you please resurrect this very useful package?

@JordiManyer
Copy link
Member

JordiManyer commented Sep 6, 2024

@ovanvincq has a branch going on with some nice-looking changes. Is it functional? If so, I'm happy to accept a PR and merge the changes for everyone.

@JordiManyer
Copy link
Member

Actually I'm blind, there is a PR already, see #73

@JordiManyer
Copy link
Member

The PR has been merged, and it seems like the tests pass. I'll do the next release some day next week (once we fix the small issue we are having with the documenter keys).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants