Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Wrong" normal #24

Closed
santiagobadia opened this issue Jun 8, 2020 · 2 comments
Closed

"Wrong" normal #24

santiagobadia opened this issue Jun 8, 2020 · 2 comments

Comments

@santiagobadia
Copy link
Member

Hi @oriolcg

I think that it is far better to always put the normal before the stress tensor, i.e., n * sigma instead of sigma * n. The reason is that it comes from the integration by parts formula and Gauss theorem, and for non-symmetric second order tensors, the result is different. For instance, if you use a vector Laplacian instead of a Laplacian and you have written your fluxes as grad(u) * n, if you move to vectors, this is an error.

I know that for your fluid, solid, and FSI problems it is not an issue, but I think it is good practise. Could you change the tutorials accordignly? Both the one already in the main branch and the one to the merge?

Thanks!

@oriolcg
Copy link
Member

oriolcg commented Jun 9, 2020

Sure! I can take care of that.

@oriolcg
Copy link
Member

oriolcg commented Jun 10, 2020

Done in the latest commits of PR #23 and PR #25

@oriolcg oriolcg closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants